On Mon, Aug 24, 2020 at 10:47:23AM -0300, Jason Gunthorpe wrote: > On Sun, Aug 23, 2020 at 10:45:58PM +0300, Kamal Heib wrote: > > On Thu, Aug 20, 2020 at 08:37:17AM -0300, Jason Gunthorpe wrote: > > > On Wed, Aug 19, 2020 at 12:15:45AM +0300, Kamal Heib wrote: > > > > On Tue, Aug 18, 2020 at 01:31:57PM -0300, Jason Gunthorpe wrote: > > > > > On Tue, Aug 18, 2020 at 05:25:04PM +0300, Kamal Heib wrote: > > > > > > To avoid the following kernel panic when calling kmem_cache_create() > > > > > > with a NULL pointer from pool_cache(), move the rxe_cache_init() to the > > > > > > context of device initialization. > > > > > > > > > > I think you've hit on a bigger bug than just this oops. > > > > > > > > > > rxe_net_add() should never be called before rxe_module_init(), that > > > > > surely subtly breaks all kinds of things. > > > > > > > > > > Maybe it is time to remove these module parameters? > > > > > > > > > Yes, I agree, this can be done in for-next. > > > > > > > > But at least can we take this patch to for-rc (stable) to fix this issue > > > > in stable releases? > > > > > > If you want to fix something in stable then block the module options > > > from working as actual module options - eg before rxe_module_init() > > > runs. > > > > > > Jason > > > > Something like the following patch? > > Yes, something more like that > > Jason OK, Thanks! I'll send v3 soon. Thanks, Kamal
