Re: [PATCH v2 for-rc] RDMA/rxe: Fix panic when calling kmem_cache_create()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 18, 2020 at 01:31:57PM -0300, Jason Gunthorpe wrote:
> On Tue, Aug 18, 2020 at 05:25:04PM +0300, Kamal Heib wrote:
> > To avoid the following kernel panic when calling kmem_cache_create()
> > with a NULL pointer from pool_cache(), move the rxe_cache_init() to the
> > context of device initialization.
> 
> I think you've hit on a bigger bug than just this oops.
> 
> rxe_net_add() should never be called before rxe_module_init(), that
> surely subtly breaks all kinds of things.
> 
> Maybe it is time to remove these module parameters?
>
Yes, I agree, this can be done in for-next.

But at least can we take this patch to for-rc (stable) to fix this issue
in stable releases?

Thanks,
Kamal

> Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux