> On Jul 20, 2020, at 10:00 AM, Jason Gunthorpe <jgg@xxxxxxxx> wrote: > > On Fri, Jul 10, 2020 at 12:32:28PM -0400, Chuck Lever wrote: >> >> >>> On Jul 10, 2020, at 11:17 AM, Jason Gunthorpe <jgg@xxxxxxxx> wrote: >>> >>> On Fri, Jul 10, 2020 at 10:06:01AM -0400, Chuck Lever wrote: >>>> Hi- >>>> >>>> This is a Request For Comments. >>>> >>>> Oracle has an interest in a common observability infrastructure in >>>> the RDMA core and ULPs. One alternative for this infrastructure is >>>> to introduce static tracepoints that can also be used as hooks for >>>> eBPF scripts, replacing infrastructure that is based on printk. >>> >>> Don't we already have tracepoints in CM, why is adding more RFC? >> >> One of these patches _replaces_ printk calls with tracepoints. >> Is that OK? > > Seems OK? I'd rather have the trace points be self consistent than a mix > of things spilling into pr_debug. Exactly, but I wanted to be sure the community (and especially authors of driver/infiniband/core/cm.c) agrees with this view. I will follow up with a v2 this week with a few fixes and tweaks. > If someone wants to debug the CM it is clearly better to use the > complete set of tracepoints, right? -- Chuck Lever
