On Sun, Jun 28, 2020 at 05:50:03PM +0300, Alaa Hleihel wrote:
> The cited commit enabled pyverbs build by default for Fedora 32 and up.
> However, it broke enalbing pyverbs build when passing '--with pyverbs' flag.
>
> Fix the condition so that now the behavior for Fedora 32 and up will be:
> * Default: pyverbs enabled.
Confirmed this patch works for me. Thanks!
Acked-by: Honggang Li <honli@xxxxxxxxxx>
> * --with pyverbs: pyverbs enabled.
> * --without pyverbs: pyverbs disabled.
>
> Fixes: 07b304b75186 ("redhat: Build pyverbs for Fedora greater than release 31")
> Signed-off-by: Alaa Hleihel <alaa@xxxxxxxxxxxx>
> Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> Tested-by: Edward Srouji <edwards@xxxxxxxxxxxx>
> CC: Honggang Li <honli@xxxxxxxxxx>
> ---
> redhat/rdma-core.spec | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/redhat/rdma-core.spec b/redhat/rdma-core.spec
> index 7ff33b3ca8b8..76549e5cb61f 100644
> --- a/redhat/rdma-core.spec
> +++ b/redhat/rdma-core.spec
> @@ -28,7 +28,7 @@ BuildRequires: valgrind-devel
> BuildRequires: systemd
> BuildRequires: systemd-devel
> %if 0%{?fedora} >= 32
> -%define with_pyverbs %{?_with_pyverbs: 0} %{?!_with_pyverbs: 1}
> +%define with_pyverbs %{?_with_pyverbs: 1} %{?!_with_pyverbs: %{?!_without_pyverbs: 1} %{?_without_pyverbs: 0}}
> %else
> %define with_pyverbs %{?_with_pyverbs: 1} %{?!_with_pyverbs: 0}
> %endif
> --
> 2.26.2
>
