On Wed, Jun 24, 2020 at 01:54:22PM +0300, Leon Romanovsky wrote: > @@ -4018,8 +4028,7 @@ const struct uapi_definition uverbs_def_write_intf[] = { > IB_USER_VERBS_EX_CMD_DESTROY_RWQ_IND_TBL, > ib_uverbs_ex_destroy_rwq_ind_table, > UAPI_DEF_WRITE_I( > - struct ib_uverbs_ex_destroy_rwq_ind_table), > - UAPI_DEF_METHOD_NEEDS_FN(destroy_rwq_ind_table))), > + struct ib_uverbs_ex_destroy_rwq_ind_table))), Removing these is kind of troublesome.. This misses the one for ioctl: UAPI_DEF_CHAIN_OBJ_TREE_NAMED( UVERBS_OBJECT_RWQ_IND_TBL, UAPI_DEF_OBJ_NEEDS_FN(destroy_rwq_ind_table)), > diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c > index 65c9118a931c..4210f0842bc6 100644 > +++ b/drivers/infiniband/core/verbs.c > @@ -1703,7 +1703,7 @@ static int _ib_modify_qp(struct ib_qp *qp, struct ib_qp_attr *attr, > &old_sgid_attr_alt_av); > if (ret) > goto out_av; > - > +// ?? Jason