Hi, On 16/06/2020 05.08, Greg Kroah-Hartman wrote: >> I considered backporting commit 8966e28d2e40c ("IB/ipoib: Use NAPI in UD/TX flows") >> with all the dependencies it may have a considerably higher risk >> than just arming the TX CQ. > > 90% of the time when we apply a patch that does NOT match the upstream > tree, it has a bug in it and needs to have another fix or something > else. > > So please, if at all possible, stick to the upstream tree, so > backporting the current patches are the best thing to do. > Jason, With Mellanox writing and fixing the vast majority of the code found in IB/IPoIB, do you or one of your colleagues want to look into this? It would be considerably less error-prone if the authors of that code did that more risky work of backporting. AFAIK, Mellanox also has the regression tests to ensure that everything still works after this re-write as it did before. Thanks, Gerd