On Fri, Jun 12, 2020 at 01:44:55PM -0700, Gerd Rausch wrote:
> Hi Jason,
>
> On 12/06/2020 12.55, Jason Gunthorpe wrote:
> > On Fri, Jun 12, 2020 at 12:41:16PM -0700, Gerd Rausch wrote:
> >> This issue appears to no longer exist in Linux-4.15
> >> and younger, because the following commit does
> >> call "ib_req_notify_cq" on "send_cq":
> >> 8966e28d2e40c ("IB/ipoib: Use NAPI in UD/TX flows")
> >
> > I'm not really clear what you want to happen to this patch - are you
> > proposing a stable patch that is not just a backport? Why can't you
> > backport the fix above instead?
>
> I considered backporting commit 8966e28d2e40c ("IB/ipoib: Use NAPI in UD/TX flows")
> with all the dependencies it may have a considerably higher risk
> than just arming the TX CQ.
90% of the time when we apply a patch that does NOT match the upstream
tree, it has a bug in it and needs to have another fix or something
else.
So please, if at all possible, stick to the upstream tree, so
backporting the current patches are the best thing to do.
thanks,
greg k-h
