> -----Original Message----- > From: Leon Romanovsky <leon@xxxxxxxxxx> > Sent: Tuesday, May 12, 2020 1:57 AM > To: Dalessandro, Dennis <dennis.dalessandro@xxxxxxxxx> > Cc: jgg@xxxxxxxx; dledford@xxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; > Marciniszyn, Mike <mike.marciniszyn@xxxxxxxxx>; stable@xxxxxxxxxxxxxxx; > Wan, Kaike <kaike.wan@xxxxxxxxx> > Subject: Re: [PATCH for-rc or next 2/3] IB/hfi1: Do not destroy link_wq when > the device is shut down > > On Mon, May 11, 2020 at 11:13:22PM -0400, Dennis Dalessandro wrote: > > From: Kaike Wan <kaike.wan@xxxxxxxxx> > > > > The workqueue link_wq should only be destroyed when the hfi1 driver is > > unloaded, not when the device is shut down. > > It really doesn't make sense to keep workqueue if no devices exist. > Only to keep consistent with the other workqueue: hfi1_wq. Both workqueues are created when the probe function of the pci_driver is called and destroyed when the remove function is called. In addition, we try not to free any data structure in the shutdown function, which is intended to change the power state of a device before reboot (include/linux/pci.h comment). Kaike
