Re: [PATCH for-rc or next 2/3] IB/hfi1: Do not destroy link_wq when the device is shut down

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH for-rc or next 2/3] IB/hfi1: Do not destroy link_wq when the device is shut down
From: Leon Romanovsky <leon@xxxxxxxxxx>
Date: Tue, 12 May 2020 08:56:57 +0300
Cc: jgg@xxxxxxxx, dledford@xxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx>, stable@xxxxxxxxxxxxxxx, Kaike Wan <kaike.wan@xxxxxxxxx>
In-reply-to: <20200512031322.189865.4129.stgit@awfm-01.aw.intel.com>
References: <20200512030622.189865.65024.stgit@awfm-01.aw.intel.com> <20200512031322.189865.4129.stgit@awfm-01.aw.intel.com>

On Mon, May 11, 2020 at 11:13:22PM -0400, Dennis Dalessandro wrote:
> From: Kaike Wan <kaike.wan@xxxxxxxxx>
>
> The workqueue link_wq should only be destroyed when the hfi1 driver
> is unloaded, not when the device is shut down.

It really doesn't make sense to keep workqueue if no devices exist.

Thanks

Follow-Ups:
- RE: [PATCH for-rc or next 2/3] IB/hfi1: Do not destroy link_wq when the device is shut down
  - From: Wan, Kaike

References:
- [PATCH for-rc or next 0/3] minor hfi and qib fixes
  - From: Dennis Dalessandro
- [PATCH for-rc or next 2/3] IB/hfi1: Do not destroy link_wq when the device is shut down
  - From: Dennis Dalessandro

Prev by Date: Re: [PATCH for-rc or next 1/3] IB/hfi1: Do not destroy hfi1_wq when the device is shut down
Next by Date: Re: [PATCH for-rc or next 3/3] IB/qib: Call kobject_put() when kobject_init_and_add() fails
Previous by thread: [PATCH for-rc or next 2/3] IB/hfi1: Do not destroy link_wq when the device is shut down
Next by thread: RE: [PATCH for-rc or next 2/3] IB/hfi1: Do not destroy link_wq when the device is shut down
Index(es):
- Date
- Thread

[Index of Archives] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Photo] [Yosemite News] [Yosemite Photos] [Linux Kernel] [Linux SCSI] [XFree86]