On 2020/4/28 19:10, Jonathan Cameron wrote: > On Tue, 28 Apr 2020 16:12:39 +0800 > liweihang <liweihang@xxxxxxxxxx> wrote: > >> On 2020/4/28 10:53, kbuild test robot wrote: >>> Hi Weihang, >>> >>> I love your patch! Perhaps something to improve: >>> >>> [auto build test WARNING on rdma/for-next] >>> [also build test WARNING on linus/master v5.7-rc3 next-20200424] >>> [if your patch is applied to the wrong git tree, please drop us a note to help >>> improve the system. BTW, we also suggest to use '--base' option to specify the >>> base tree in git format-patch, please see https://stackoverflow.com/a/37406982] >>> >>> url: https://github.com/0day-ci/linux/commits/Weihang-Li/RDMA-hns-Refactor-process-of-buffer-allocation-and-calculation/20200428-015905 >>> base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next >>> reproduce: >>> # apt-get install sparse >>> # sparse version: v0.6.1-191-gc51a0382-dirty >>> make ARCH=x86_64 allmodconfig >>> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kbuild test robot <lkp@xxxxxxxxx> >>> >>> >>> sparse warnings: (new ones prefixed by >>) >>> >>>>> drivers/infiniband/hw/hns/hns_roce_mr.c:375:6: sparse: sparse: symbol 'hns_roce_mr_free' was not declared. Should it be static? >>> >>> Please review and possibly fold the followup patch. >>> >>> --- >>> 0-DAY CI Kernel Test Service, Intel Corporation >>> https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx >>> >> >> It will be used out of this file in later series, but it's better to add >> a static currently. Will fix it, thanks. > > Alternative would be to declare it in the header at this stage. > > Jonathan > Hi Jonathan, I see, but I have already sent v4. Thanks for your advice and I will follow your comments next time. Thanks Weihang > >> >> Weihang >> >> >> _______________________________________________ >> Linuxarm mailing list >> Linuxarm@xxxxxxxxxx >> http://hulk.huawei.com/mailman/listinfo/linuxarm > > >
