On Wed, Feb 26, 2020 at 02:08:52PM +0000, Marciniszyn, Mike wrote: > > > You mean this one? https://marc.info/?l=linux- > > rdma&m=158263596831342&w=2 > > > > Ok. I will test the patch. > > > Yes, this is what I wanted to achieve by "if (!(qp_attr_mask & > > (IB_QP_PKEY_INDEX || IB_QP_PORT)) && qp_pps) {" line. > > Was a non-bitwise || what was intended in this statememt? No, another mistake, see commit commit 4ca501d6aaf21de31541deac35128bbea8427aa6 Author: Nathan Chancellor <natechancellor@xxxxxxxxx> Date: Mon Feb 17 13:43:18 2020 -0700 RDMA/core: Fix use of logical OR in get_new_pps It is still mystery but we didn't see failures with "broken" code. Thanks > > > > Mike
