On 2/3/20 10:37 AM, "Yuval Shaia yuval.shaia.ml"@gmail.com wrote:
> From: Yuval Shaia <yuval.shaia.ml@xxxxxxxxx>
>
> We need to disable the PCI device on any error happen after we enable
> the device.
>
> Signed-off-by: Yuval Shaia <yuval.shaia.ml@xxxxxxxxx>
> ---
> drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
> index e580ae9cc55a..780fd2dfc07e 100644
> --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
> +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
> @@ -829,7 +829,7 @@ static int pvrdma_pci_probe(struct pci_dev *pdev,
> !(pci_resource_flags(pdev, 1) & IORESOURCE_MEM)) {
> dev_err(&pdev->dev, "PCI BAR region not MMIO\n");
> ret = -ENOMEM;
> - goto err_free_device;
> + goto err_disable_pdev;
> }
>
> ret = pci_request_regions(pdev, DRV_NAME);
>
Looks fine to me. Please add a Fixes tag and cc stable.
Acked-by: Adit Ranadive <aditr@xxxxxxxxxx>
