On 2/3/20 10:36 AM, "Yuval Shaia yuval.shaia.ml"@gmail.com wrote: > From: Yuval Shaia <yuval.shaia.ml@xxxxxxxxx> > > From Documentation/PCI/pci.tx.txt: > Drivers should call pci_release_region() after calling > pci_disable_device() in order to prevent two devices colliding on the > same address range. > > Signed-off-by: Yuval Shaia <yuval.shaia.ml@xxxxxxxxx> > --- > drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c > index 780fd2dfc07e..3ef5b4b60f42 100644 > --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c > +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c > @@ -1137,8 +1137,8 @@ static void pvrdma_pci_remove(struct pci_dev *pdev) > ib_dealloc_device(&dev->ib_dev); > > /* Free pci resources */ > - pci_release_regions(pdev); > pci_disable_device(pdev); > + pci_release_regions(pdev); > pci_set_drvdata(pdev, NULL); > } > > Looks fine to me. Please add a Fixes tag and cc stable. Acked-by: Adit Ranadive <aditr@xxxxxxxxxx>
