On Tue, Dec 3, 2019 at 10:25 AM Bart Van Assche <bvanassche@xxxxxxx> wrote: > > On 12/2/19 6:03 PM, Steve Wise wrote: > > If RoCE PDUs being sent or received contain pad bytes, then the iCRC > > is miscalculated resulting PDUs being emitted by RXE with an incorrect > > iCRC, as well as ingress PDUs being dropped due to erroneously detecting > > a bad iCRC in the PDU. The fix is to include the pad bytes, if any, > > in iCRC computations. > > Should this description mention that this patch breaks compatibility > with SoftRoCE drivers that do not include this fix? Do we need a kernel > module parameter that allows to select either the old or the new behavior? > Good point. I defer to others on how they want to handle that. > > CC: bvanassche@xxxxxxx,3100102071@xxxxxxxxxx,leon@xxxxxxxxxx > > Should this Cc-line perhaps be converted into three Cc-lines? Yea I screwed this up. I really didn't want this in the commit log vs just CCing on the email submission, but I was having issues with git send-email. Pilot error. ;) Stevo
