On 12/2/19 6:03 PM, Steve Wise wrote:
If RoCE PDUs being sent or received contain pad bytes, then the iCRC is miscalculated resulting PDUs being emitted by RXE with an incorrect iCRC, as well as ingress PDUs being dropped due to erroneously detecting a bad iCRC in the PDU. The fix is to include the pad bytes, if any, in iCRC computations.
Should this description mention that this patch breaks compatibility with SoftRoCE drivers that do not include this fix? Do we need a kernel module parameter that allows to select either the old or the new behavior?
CC: bvanassche@xxxxxxx,3100102071@xxxxxxxxxx,leon@xxxxxxxxxx
Should this Cc-line perhaps be converted into three Cc-lines? Otherwise this patch looks fine to me. Thanks, Bart.
