> From: Jason Gunthorpe <jgg@xxxxxxxx>
> Sent: Thursday, October 24, 2019 9:08 PM
>
> External Email
>
> ----------------------------------------------------------------------
> On Thu, Oct 24, 2019 at 08:52:51PM +0300, Michal Kalderon wrote:
> > The qpids xarray isn't accessed from irq context and therefore there
> > is no need to use the xa_XXX_irq version of the apis.
> > Remove the _irq.
> >
> > Fixes: b6014f9e5f39 ("qedr: Convert qpidr to XArray")
> > Signed-off-by: Ariel Elior <ariel.elior@xxxxxxxxxxx>
> > Signed-off-by: Michal Kalderon <michal.kalderon@xxxxxxxxxxx>
> > drivers/infiniband/hw/qedr/main.c | 1 -
> > drivers/infiniband/hw/qedr/qedr_iw_cm.c | 2 +-
> > drivers/infiniband/hw/qedr/verbs.c | 4 ++--
> > 3 files changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/qedr/main.c
> > b/drivers/infiniband/hw/qedr/main.c
> > index 5136b835e1ba..432dff95a7aa 100644
> > +++ b/drivers/infiniband/hw/qedr/main.c
> > @@ -359,7 +359,6 @@ static int qedr_alloc_resources(struct qedr_dev
> *dev)
> > spin_lock_init(&dev->sgid_lock);
> >
> > if (IS_IWARP(dev)) {
> > - xa_init_flags(&dev->qps, XA_FLAGS_LOCK_IRQ);
>
> The xarray still has to be init'd, surely?
Yes, you're right, not sure how this slipped and passed regressions (perhaps since eventually init zeroes everything).
I just noticed that in original
Commit for srqs xarray 9fd15987ed27 ("qedr: Convert srqidr to XArray") there was no
Call to xa_init or xa_init_flags either. Will fix that as well in v4.
Thanks.
>
> Jason
