Re: [PATCH v3 rdma-next 1/3] RDMA/qedr: Fix qpids xarray api used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 24, 2019 at 08:52:51PM +0300, Michal Kalderon wrote:
> The qpids xarray isn't accessed from irq context and therefore there
> is no need to use the xa_XXX_irq version of the apis.
> Remove the _irq.
> 
> Fixes: b6014f9e5f39 ("qedr: Convert qpidr to XArray")
> Signed-off-by: Ariel Elior <ariel.elior@xxxxxxxxxxx>
> Signed-off-by: Michal Kalderon <michal.kalderon@xxxxxxxxxxx>
>  drivers/infiniband/hw/qedr/main.c       | 1 -
>  drivers/infiniband/hw/qedr/qedr_iw_cm.c | 2 +-
>  drivers/infiniband/hw/qedr/verbs.c      | 4 ++--
>  3 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c
> index 5136b835e1ba..432dff95a7aa 100644
> +++ b/drivers/infiniband/hw/qedr/main.c
> @@ -359,7 +359,6 @@ static int qedr_alloc_resources(struct qedr_dev *dev)
>  	spin_lock_init(&dev->sgid_lock);
>  
>  	if (IS_IWARP(dev)) {
> -		xa_init_flags(&dev->qps, XA_FLAGS_LOCK_IRQ);

The xarray still has to be init'd, surely?

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux