Re: [PATCH mlx5-next v2 1/3] net/mlx5: Expose optimal performance scatter entries capability

Subject: Re: [PATCH mlx5-next v2 1/3] net/mlx5: Expose optimal performance scatter entries capability
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Mon, 7 Oct 2019 08:02:50 -0700
Cc: Leon Romanovsky <leonro@xxxxxxxxxxxx>, RDMA mailing list <linux-rdma@xxxxxxxxxxxxxxx>, Or Gerlitz <ogerlitz@xxxxxxxxxxxx>, Yamin Friedman <yaminf@xxxxxxxxxxxx>, Saeed Mahameed <saeedm@xxxxxxxxxxxx>, linux-netdev <netdev@xxxxxxxxxxxxxxx>
In-reply-to: <20191007135933.12483-2-leon@kernel.org>
References: <20191007135933.12483-1-leon@kernel.org> <20191007135933.12483-2-leon@kernel.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

On 10/7/19 6:59 AM, Leon Romanovsky wrote:

-	u8         reserved_at_c0[0x8];
+	u8         max_sgl_for_optimized_performance[0x8];

Should the name of this member variable perhaps be changed into"max_sgl_for_optimal_performance"?


Thanks,

Bart.

Follow-Ups:
- Re: [PATCH mlx5-next v2 1/3] net/mlx5: Expose optimal performance scatter entries capability
  - From: Leon Romanovsky

References:
- [PATCH rdma-next v2 0/3] Optimize SGL registration
  - From: Leon Romanovsky
- [PATCH mlx5-next v2 1/3] net/mlx5: Expose optimal performance scatter entries capability
  - From: Leon Romanovsky