On Wed, Aug 28, 2019 at 09:56:46PM +0300, Yuval Shaia wrote:
> On Wed, Aug 28, 2019 at 01:53:12PM +0000, Jason Gunthorpe wrote:
> > On Wed, Aug 28, 2019 at 12:15:33PM +0300, Yuval Shaia wrote:
> > > static int fill_res_pd_entry(struct sk_buff *msg, bool has_cap_net_admin,
> > > struct rdma_restrack_entry *res, uint32_t port)
> > > {
> > > struct ib_pd *pd = container_of(res, struct ib_pd, res);
> > > struct ib_device *dev = pd->device;
> > > + struct nlattr *table_attr = NULL;
> > > + struct nlattr *entry_attr = NULL;
> > > + struct context_id *ctx_id;
> > > + struct context_id *tmp;
> > > + LIST_HEAD(pd_context_ids);
> > > + int ctx_count = 0;
> > >
> > > if (has_cap_net_admin) {
> > > if (nla_put_u32(msg, RDMA_NLDEV_ATTR_RES_LOCAL_DMA_LKEY,
> > > @@ -633,10 +709,38 @@ static int fill_res_pd_entry(struct sk_buff *msg, bool has_cap_net_admin,
> > > if (nla_put_u32(msg, RDMA_NLDEV_ATTR_RES_PDN, res->id))
> > > goto err;
> > >
> > > - if (!rdma_is_kernel_res(res) &&
> > > - nla_put_u32(msg, RDMA_NLDEV_ATTR_RES_CTXN,
> > > - pd->uobject->context->res.id))
> > > - goto err;
> >
> > How do earlier patches compile?
>
> They did not
That is not OK
Jason
