-----"Doug Ledford" <dledford@xxxxxxxxxx> wrote: ----- >To: "Jason Gunthorpe" <jgg@xxxxxxxx>, "Bernard Metzler" ><bmt@xxxxxxxxxxxxxx> >From: "Doug Ledford" <dledford@xxxxxxxxxx> >Date: 08/06/2019 02:33PM >Cc: linux-rdma@xxxxxxxxxxxxxxx >Subject: [EXTERNAL] Re: [PATCH 1/1] Make user mmapped CQ arming flags >field 32 bit size to remove 64 bit architecture dependency of siw. > >On Tue, 2019-08-06 at 09:10 -0300, Jason Gunthorpe wrote: >> On Mon, Aug 05, 2019 at 04:17:08PM +0200, Bernard Metzler wrote: >> > Signed-off-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx> >> > --- >> >> Don't send patches with empty commit messages. Every patch must >have a >> comprehensive commit message from now on. >> >> > drivers/infiniband/sw/siw/Kconfig | 2 +- >> > drivers/infiniband/sw/siw/siw.h | 2 +- >> > drivers/infiniband/sw/siw/siw_qp.c | 14 ++++++++++---- > >He had a decent commit log message, it was just in the cover letter. >Bernard, on single patch submissions, skip the cover letter and just >send the patch by itself. Then the nice explanation you gave in the >cover letter should go in the commit message itself. > sorry about this. Frankly I am still newbie here and obviously and unfortunately behave like this... A lame excuse, but I'll try hard to improve. Bernard.