On Tue, 2019-08-06 at 09:10 -0300, Jason Gunthorpe wrote: > On Mon, Aug 05, 2019 at 04:17:08PM +0200, Bernard Metzler wrote: > > Signed-off-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx> > > --- > > Don't send patches with empty commit messages. Every patch must have a > comprehensive commit message from now on. > > > drivers/infiniband/sw/siw/Kconfig | 2 +- > > drivers/infiniband/sw/siw/siw.h | 2 +- > > drivers/infiniband/sw/siw/siw_qp.c | 14 ++++++++++---- He had a decent commit log message, it was just in the cover letter. Bernard, on single patch submissions, skip the cover letter and just send the patch by itself. Then the nice explanation you gave in the cover letter should go in the commit message itself. -- Doug Ledford <dledford@xxxxxxxxxx> GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Attachment:
signature.asc
Description: This is a digitally signed message part