On 6/27/2019 8:42 PM, Fuqian Huang wrote: > In commit af7ddd8a627c > ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), > dma_alloc_coherent has already zeroed the memory. > So memset is not needed. > > Signed-off-by: Fuqian Huang <huangfq.daxian@xxxxxxxxx> > --- > drivers/net/ethernet/mellanox/mlx4/eq.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c > index a5be27772b8e..c790a5fcea73 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/eq.c > +++ b/drivers/net/ethernet/mellanox/mlx4/eq.c > @@ -1013,8 +1013,6 @@ static int mlx4_create_eq(struct mlx4_dev *dev, int nent, > > dma_list[i] = t; > eq->page_list[i].map = t; > - > - memset(eq->page_list[i].buf, 0, PAGE_SIZE); > } > > eq->eqn = mlx4_bitmap_alloc(&priv->eq_table.bitmap); > Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxxxx> Thanks.