-----"Doug Ledford" <dledford@xxxxxxxxxx> wrote: ----- >To: "Bart Van Assche" <bvanassche@xxxxxxx>, "Bernard Metzler" ><bmt@xxxxxxxxxxxxxx>, linux-rdma@xxxxxxxxxxxxxxx >From: "Doug Ledford" <dledford@xxxxxxxxxx> >Date: 06/22/2019 12:28AM >Subject: [EXTERNAL] Re: [PATCH v3 05/11] SIW application interface > >On Thu, 2019-06-20 at 09:33 -0700, Bart Van Assche wrote: >> On 6/20/19 9:21 AM, Bernard Metzler wrote: >> > diff --git a/include/uapi/rdma/siw-abi.h b/include/uapi/rdma/siw- >> > abi.h >> > new file mode 100644 >> > index 000000000000..3dd8071ace7b >> > --- /dev/null >> > +++ b/include/uapi/rdma/siw-abi.h >> > @@ -0,0 +1,185 @@ >> > +/* SPDX-License-Identifier: GPL-2.0 or BSD-3-Clause */ >> > + >> > +/* Authors: Bernard Metzler <bmt@xxxxxxxxxxxxxx> */ >> > +/* Copyright (c) 2008-2019, IBM Corporation */ >> > + >> > +#ifndef _SIW_USER_H >> > +#define _SIW_USER_H >> > + >> > +#include <linux/types.h> >> > + >> > +#define SIW_NODE_DESC_COMMON "Software iWARP stack" >> >> How can the definition of a string like this be useful in an UAPI >> header >> file? If user space code doesn't need this string please move this >> definition away from include/uapi. >> >> > +#define SIW_ABI_VERSION 1 >> >> Same question here: how can this definition be useful in an UAPI >> header >> file? As you know Linux user space APIs must be backwards >compatible. > >I moved both of these to sw/siw/siw.h instead of the uapi header. > Thanks Doug! Bernard. >-- >Doug Ledford <dledford@xxxxxxxxxx> > GPG KeyID: B826A3330E572FDD > Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD > [attachment "signature.asc" removed by Bernard Metzler/Zurich/IBM]
