-----"Bart Van Assche" <bvanassche@xxxxxxx> wrote: ----- >To: "Bernard Metzler" <bmt@xxxxxxxxxxxxxx>, >linux-rdma@xxxxxxxxxxxxxxx >From: "Bart Van Assche" <bvanassche@xxxxxxx> >Date: 06/20/2019 06:33PM >Subject: [EXTERNAL] Re: [PATCH v3 05/11] SIW application interface > >On 6/20/19 9:21 AM, Bernard Metzler wrote: >> diff --git a/include/uapi/rdma/siw-abi.h >b/include/uapi/rdma/siw-abi.h >> new file mode 100644 >> index 000000000000..3dd8071ace7b >> --- /dev/null >> +++ b/include/uapi/rdma/siw-abi.h >> @@ -0,0 +1,185 @@ >> +/* SPDX-License-Identifier: GPL-2.0 or BSD-3-Clause */ >> + >> +/* Authors: Bernard Metzler <bmt@xxxxxxxxxxxxxx> */ >> +/* Copyright (c) 2008-2019, IBM Corporation */ >> + >> +#ifndef _SIW_USER_H >> +#define _SIW_USER_H >> + >> +#include <linux/types.h> >> + >> +#define SIW_NODE_DESC_COMMON "Software iWARP stack" > >How can the definition of a string like this be useful in an UAPI >header >file? If user space code doesn't need this string please move this >definition away from include/uapi. OK, I had that in as another possible check from user lib if the kernel driver matches. Not really needed. I can remove it... > >> +#define SIW_ABI_VERSION 1 > >Same question here: how can this definition be useful in an UAPI >header >file? As you know Linux user space APIs must be backwards compatible. Don't get that one yet. The kernel driver announces its abi version (via uverbs_abi_ver) and user land lib get's checked if it is in range (between match_min_abi_version and match_max_abi_version). See e.g. efa, pvrdma, mqedr, bnxt .... other drivers. It's always in the shared abi file then. Thanks, Bernard.
