On Fri, Jun 07, 2019 at 02:42:58PM -0300, Jason Gunthorpe wrote: > On Fri, Jun 07, 2019 at 12:23:45PM -0500, Steve Wise wrote: > > On Fri, Jun 7, 2019 at 11:24 AM Jason Gunthorpe <jgg@xxxxxxxx> wrote: > > > > > > Since we have gained another two (EFA, SIW) drivers lately, I'd really > > > like to remove NES as we have in the past for other drivers. > > > > > > This hardware was proposed to be removed at the last purge, but I > > > think that Steve still wanted to keep it for some reason. I suppose > > > that has changed now. > > > > > > If I recall the reasons for removal were basically: > > > - Does not support modern FRWR, which is now becoming mandatory for ULPs > > > - Does not support 64 bit physical addresses, so is useless on modern > > > servers > > > - Possibly nobody has even loaded the module in years. Wouldn't be > > > surprised to learn it is broken with all the recent churn. > > > > > > Remarkably there still seem to be cards in ebay though.. > > > > > > Jason > > > > It wasn't me. > > Oh? I wonder who.. I have same feeling like Jason, that it was you. > > > Perhaps we were discussing cxgb3 removal? > > I know we discussed that :) can we remove cxgb3? :) Ohh, good, I would like to remove UCM too, we waited enough. > > > Anyway, are you certain it doesn't support REG_MR? I see support > > for it in nes_post_send(). > > Hm, not really, but I thought it was one of the ones. It does set > IB_DEVICE_MEM_MGT_EXTENSIONS so I guess it is OK. > > Jason
