Re: [PATCH 15/20] RDMA/core: Validate signature handover device cap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




-    if (qp_init_attr->rwq_ind_tbl &&
-        (qp_init_attr->recv_cq ||
-        qp_init_attr->srq || qp_init_attr->cap.max_recv_wr ||
-        qp_init_attr->cap.max_recv_sge))
+    if ((qp_init_attr->rwq_ind_tbl &&
+         (qp_init_attr->recv_cq ||
+          qp_init_attr->srq || qp_init_attr->cap.max_recv_wr ||
+          qp_init_attr->cap.max_recv_sge)) ||
+        ((qp_init_attr->create_flags & IB_QP_CREATE_SIGNATURE_EN) &&
+         !(device->attrs.device_cap_flags & IB_DEVICE_SIGNATURE_HANDOVER)))

Wouldn't it make sense to also change the qp create flag and the device
cap to be PI_EN/PI_HANDOVER while we're at it?

We're already standing on 20 patches in this series, so if Jason will agree I'll do this renaming in a separate commit or we can stay with the current naming.

This is a good chance to clean the naming here. Ideally we can also
cleanup the naming on the call-sites and get rid of the signature
name everywhere (since we ended up doing only the pi subset), but that indeed can be a followup.

This can come as a separate patch.



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux