On Tue, Apr 30, 2019 at 03:21:58PM +0300, Gal Pressman wrote:
> On 30-Apr-19 15:07, Leon Romanovsky wrote:
> > On Tue, Apr 30, 2019 at 02:38:30PM +0300, Gal Pressman wrote:
> >> On 30-Apr-19 14:35, Dennis Dalessandro wrote:
> >>> On 4/30/2019 7:27 AM, Gal Pressman wrote:
> >>>> On 30-Apr-19 14:18, Leon Romanovsky wrote:
> >>>>> On Tue, Apr 30, 2019 at 11:46:39AM +0300, Gal Pressman wrote:
> >>>>>> Cited commit introduced the udata parameter to different destroy flows
> >>>>>> but the uapi method definition does not have udata (i.e has_udata flag
> >>>>>> is not set). As a result, an uninitialized udata struct is being passed
> >>>>>> down to the driver callbacks.
> >>>>>>
> >>>>>> Fix that by clearing the driver udata even in cases where has_udata flag
> >>>>>> is not set.
> >>>>>>
> >>>>>> Fixes: c4367a26357b ("IB: Pass uverbs_attr_bundle down ib_x destroy path")
> >>>>>> Cc: Shamir Rabinovitch <shamir.rabinovitch@xxxxxxxxxx>
> >>>>>> Co-developed-by: Jason Gunthorpe <jgg@xxxxxxxx>
> >>>>>
> >>>>> What is wrong with Signed-off-by that caused you to add new tag?
> >>>>
> >>>> Jason is the one that originally wrote and sent the code, this tag seems
> >>>> appropriate.
> >>>> Obviously I don't mind removing it, it's there to give him credit..
> >>>
> >>> Did you find documentation for using that tag or did you just make it up? I
> >>> think Signed-off-by is what you want here.
> >>
> >> https://www.kernel.org/doc/html/v5.0/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
> >
> > I see no benefit of this new tag over SOB, especially for the patch which
> > has 100% code of that Co-* author.
>
> I disagree, and probably more people as well as the tag was introduced to the
> kernel in addition to the SOB.
This is exactly how bugs spread, one introduces it, other copy/paste it.
> Either way, I have no dog in this fight, the tag can be removed.
It doesn't matter, tried to figure why you added it and if i need to do it too.
>
> Jason, let me know if I should resubmit without it.
There is no need to resubmit, Jason/Doug will remove it if they think
differently from you.
