On 30-Apr-19 14:35, Dennis Dalessandro wrote:
> On 4/30/2019 7:27 AM, Gal Pressman wrote:
>> On 30-Apr-19 14:18, Leon Romanovsky wrote:
>>> On Tue, Apr 30, 2019 at 11:46:39AM +0300, Gal Pressman wrote:
>>>> Cited commit introduced the udata parameter to different destroy flows
>>>> but the uapi method definition does not have udata (i.e has_udata flag
>>>> is not set). As a result, an uninitialized udata struct is being passed
>>>> down to the driver callbacks.
>>>>
>>>> Fix that by clearing the driver udata even in cases where has_udata flag
>>>> is not set.
>>>>
>>>> Fixes: c4367a26357b ("IB: Pass uverbs_attr_bundle down ib_x destroy path")
>>>> Cc: Shamir Rabinovitch <shamir.rabinovitch@xxxxxxxxxx>
>>>> Co-developed-by: Jason Gunthorpe <jgg@xxxxxxxx>
>>>
>>> What is wrong with Signed-off-by that caused you to add new tag?
>>
>> Jason is the one that originally wrote and sent the code, this tag seems
>> appropriate.
>> Obviously I don't mind removing it, it's there to give him credit..
>
> Did you find documentation for using that tag or did you just make it up? I
> think Signed-off-by is what you want here.
https://www.kernel.org/doc/html/v5.0/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
