> -----Original Message----- > From: netdev-owner@xxxxxxxxxxxxxxx <netdev-owner@xxxxxxxxxxxxxxx> On > Behalf Of Leon Romanovsky > Sent: Monday, April 29, 2019 1:41 PM > To: Saeed Mahameed <saeedm@xxxxxxxxxxxx> > Cc: Jason Gunthorpe <jgg@xxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux- > rdma@xxxxxxxxxxxxxxx; Maor Gottlieb <maorg@xxxxxxxxxxxx>; Mark Bloch > <markb@xxxxxxxxxxxx> > Subject: Re: [PATCH V2 mlx5-next 09/11] net/mlx5: Eswitch, enable RoCE > loopback traffic > > On Mon, Apr 29, 2019 at 06:14:16PM +0000, Saeed Mahameed wrote: > > From: Maor Gottlieb <maorg@xxxxxxxxxxxx> > > > > When in switchdev mode, we would like to treat loopback RoCE traffic > > (on eswitch manager) as RDMA and not as regular Ethernet traffic In > > order to enable it we add flow steering rule that forward RoCE > > loopback traffic to the HW RoCE filter (by adding allow rule). > > In addition we add RoCE address in GID index 0, which will be set in > > the RoCE loopback packet. > > I likely don't understand nor I reviewed the patches. Part that I don't understand is GID index 0 for RoCE. RoCE traffic runs over all the GID entries and for all practical purposes from non_zero index. How will it work? It is better if you explain it in the commit log, why its done this way, 'what' part is already present the patch. > > Signed-off-by: Maor Gottlieb <maorg@xxxxxxxxxxxx> > > Reviewed-by: Mark Bloch <markb@xxxxxxxxxxxx> > > Signed-off-by: Saeed Mahameed <saeedm@xxxxxxxxxxxx> > > --- > > .../net/ethernet/mellanox/mlx5/core/Makefile | 2 +- > > .../mellanox/mlx5/core/eswitch_offloads.c | 4 + > > .../net/ethernet/mellanox/mlx5/core/rdma.c | 182 ++++++++++++++++++ > > .../net/ethernet/mellanox/mlx5/core/rdma.h | 20 ++ > > include/linux/mlx5/driver.h | 7 + > > 5 files changed, 214 insertions(+), 1 deletion(-) create mode 100644 > > drivers/net/ethernet/mellanox/mlx5/core/rdma.c > > create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/rdma.h > > > > Thanks, > Acked-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
