> -----Original Message----- > From: linux-rdma-owner@xxxxxxxxxxxxxxx <linux-rdma- > owner@xxxxxxxxxxxxxxx> On Behalf Of Marciniszyn, Mike > Sent: Monday, April 22, 2019 7:25 AM > To: Parav Pandit <parav@xxxxxxxxxxxx>; Leon Romanovsky > <leonro@xxxxxxxxxxxx> > Cc: linux-rdma@xxxxxxxxxxxxxxx > Subject: RE: new trace in RDMA next > > > > Wait. I changed it to use flags to address Jason's comment. > > > Sending you v1. > > > > > Attached one should fix it. > > The patch certainly got rid of the warning. > Thanks. I will add Tested-by tag? > I'm not sure I'm totally comfortable with the patch making a blanket > statement on future API use? > I should change from "doesn't" to "shouldn't". In general rdma subsystem wants to stay away from any sysfs device specific knobs etc. Rdma user space tool, kernel side and multiple drivers has grown well in last 2 years to give ability to users to query control device parameters. so going forward, overall drivers should use rdma tool..
