Hi Mike, > -----Original Message----- > From: linux-rdma-owner@xxxxxxxxxxxxxxx <linux-rdma- > owner@xxxxxxxxxxxxxxx> On Behalf Of Parav Pandit > Sent: Thursday, April 18, 2019 4:14 PM > To: Marciniszyn, Mike <mike.marciniszyn@xxxxxxxxx>; Leon Romanovsky > <leonro@xxxxxxxxxxxx> > Cc: linux-rdma@xxxxxxxxxxxxxxx > Subject: RE: new trace in RDMA next > > > > > -----Original Message----- > > From: Marciniszyn, Mike <mike.marciniszyn@xxxxxxxxx> > > Sent: Thursday, April 18, 2019 4:01 PM > > To: Parav Pandit <parav@xxxxxxxxxxxx>; Leon Romanovsky > > <leonro@xxxxxxxxxxxx> > > Cc: linux-rdma@xxxxxxxxxxxxxxx > > Subject: RE: new trace in RDMA next > > > > > > I don't see any xa_store() to compat_devs or use of the mutex in > > > > the > > > > ib_register_device() path? > > > > > > > The issue is not with xa_store or lock. > > > Issue is that hfi1_create_port_files() is trying to create sysfs > > > files out ppd- > > > >sc2vl_kobj, which is already initialized during ib_register_device(). > > > For every net ns, my patches are adding compat devices which > > > probably shouldn't invoke init_port for those compat devices as it not > meaningful. > > > > > > Attached patch should fix it. > > > Can you please test it? I do not have hfi hw. > > > I will inline the patch, in case attachment doesn't work. > > > > > > > I see you added the init_port arg, but I don't see that the attached > > patch reads it? > > > > I will give it a shot but... > > > Wait. I changed it to use flags to address Jason's comment. > Sending you v1. > Attached one should fix it.
Attachment:
0001-RDMA-core-Do-not-invoke-init_port-on-compat-devices.patch
Description: 0001-RDMA-core-Do-not-invoke-init_port-on-compat-devices.patch