Hi Mike, > -----Original Message----- > From: Marciniszyn, Mike <mike.marciniszyn@xxxxxxxxx> > Sent: Friday, April 19, 2019 11:39 AM > To: Parav Pandit <parav@xxxxxxxxxxxx>; Leon Romanovsky > <leonro@xxxxxxxxxxxx> > Cc: linux-rdma@xxxxxxxxxxxxxxx > Subject: RE: new trace in RDMA next > > Just a nit in the patch. > > The flag arg is a u32... > > Should it be enum ib_port_setup_flags? > I recall that some compilers doesn't take care to make enum as 64-bit even if the value is higher than 32-bit. And therefore it is safer to have storage and function argument as u32 or u64. I am not sure if this is any longer true with modern compilers. This particular flag will never likely to cross more than 32 combinations. But for sake of correctness (or rather to avoid reading gcc/c99 spec :-)) I put it as u32. > Mike
