On Wed, Mar 27, 2019 at 1:41 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote: > On Wed, Mar 27, 2019 at 12:07:54PM +0200, Or Gerlitz wrote: > > On Tue, Mar 19, 2019 at 11:25 AM Leon Romanovsky <leon@xxxxxxxxxx> wrote: > > > From: Artemy Kovalyov <artemyko@xxxxxxxxxxxx> > > > > > > Delete initialization of high order entries in mr cache to decrease initial > > > memory footprint. When required, the administrator can populate the > > > entries with memory keys via the /sys interface. > > > > Please add here: > > > > This approach is very helpful to reduce the per HW function memory > > footprint in environments such as VMs. Before the patch we see > > consumption of 0.9GB per function and after the patch about 0.1GB > > > > > Signed-off-by: Artemy Kovalyov <artemyko@xxxxxxxxxxxx> > > > Signed-off-by: Moni Shoua <monis@xxxxxxxxxxxx> > > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > > > Reported-by: Shalom Toledo <shalomt@xxxxxxxxxxxx> > > Acked-by: Or Gerlitz <ogerlitz@xxxxxxxxxxxx> > > > > Lets push it into stable kernels, a Fixes tag here will cause that > > to happen more easily, so please consider that. > I'll add it at the "apply" stage. Just to make sure, by "add it" you mean the signatures, the text and the Fixes that? Also, is there any reason not to eliminate the mr cache pre-population all together? Currently we consume 100-200MB per function after the patch which is also problematic for some environments.