Re: [PATCH mlx5-next 3/4] net/mlx5: Decrease default mr cache size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 19, 2019 at 11:25 AM Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> From: Artemy Kovalyov <artemyko@xxxxxxxxxxxx>
>
> Delete initialization of high order entries in mr cache to decrease initial
> memory footprint. When required, the administrator can populate the
> entries with memory keys via the /sys interface.

Please add here:

This approach is very helpful to reduce the per HW function memory
footprint in environments such as VMs. Before the patch we see
consumption of 0.9GB per function and after the patch about 0.1GB

> Signed-off-by: Artemy Kovalyov <artemyko@xxxxxxxxxxxx>
> Signed-off-by: Moni Shoua <monis@xxxxxxxxxxxx>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>

Reported-by:  Shalom Toledo <shalomt@xxxxxxxxxxxx>
Acked-by: Or Gerlitz <ogerlitz@xxxxxxxxxxxx>

Lets push it into stable kernels, a Fixes tag here will cause that
to happen more easily, so please consider that.

> ---
>  .../net/ethernet/mellanox/mlx5/core/main.c    | 20 -------------------
>  1 file changed, 20 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> index 70cc906a102b..76716419370d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> @@ -164,26 +164,6 @@ static struct mlx5_profile profile[] = {
>                         .size   = 8,
>                         .limit  = 4
>                 },
> -               .mr_cache[16]   = {
> -                       .size   = 8,
> -                       .limit  = 4
> -               },
> -               .mr_cache[17]   = {
> -                       .size   = 8,
> -                       .limit  = 4
> -               },
> -               .mr_cache[18]   = {
> -                       .size   = 8,
> -                       .limit  = 4
> -               },
> -               .mr_cache[19]   = {
> -                       .size   = 4,
> -                       .limit  = 2
> -               },
> -               .mr_cache[20]   = {
> -                       .size   = 4,
> -                       .limit  = 2
> -               },
>         },
>  };
>
> --
> 2.20.1
>



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux