On Tue, Mar 26, 2019 at 08:00:35PM +0800, oulijun wrote:
> 在 2019/3/26 19:51, Leon Romanovsky 写道:
> > On Tue, Mar 26, 2019 at 07:33:01PM +0800, oulijun wrote:
> >> 在 2019/3/19 17:10, Leon Romanovsky 写道:
> >>> From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> >>>
> >>> The forgotten static keyword causes to the following error to appear
> >>> while building HNS driver. Declare hns_roce_cmq_send() to be static
> >>> function to fix this warning.
> >>>
> >>> drivers/infiniband/hw/hns/hns_roce_hw_v2.c:1089:5: warning: no previous
> >>> prototype for _hns_roce_cmq_send_ [-Wmissing-prototypes]
> >>> int hns_roce_cmq_send(struct hns_roce_dev *hr_dev,
> >>>
> >>> Fixes: 6a04aed6afae ("RDMA/hns: Fix the chip hanging caused by sending mailbox&CMQ during reset")
> >>> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> >>> ---
> >>> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> >>> index 1c54390e1c85..b13436e97d1f 100644
> >>> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> >>> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> >>> @@ -1086,7 +1086,7 @@ static int __hns_roce_cmq_send(struct hns_roce_dev *hr_dev,
> >>> return ret;
> >>> }
> >>>
> >>> -int hns_roce_cmq_send(struct hns_roce_dev *hr_dev,
> >>> +static int hns_roce_cmq_send(struct hns_roce_dev *hr_dev,
> >>> struct hns_roce_cmq_desc *desc, int num)
> >>> {
> >>> int retval;
> >> Hi, Leon
> >>
> >> The patch [PATCH V9 for-next] RDMA/hns: Dump detailed driver-specific CQ will need to call the function and
> >>
> >> need it keep non-static.
> > You are not using hns_roce_cmq_send() in that v9 patch except of exposing
> > it through header file. So that v9 needs to be fixed too.
> >
> > Thanks
> No. hns_roce_cmd_send() have done in hns_roce_hw_v2.h. I merge this patch into my local branch and add the v9. it
> will build fail.
Can you please take another look on your v9? Try to search for the
hns_roce_cmq_send() and see that it is not used.
https://patchwork.kernel.org/patch/10870909/
Thanks
>
> >> Thanks.
> >>
> >> Lijun Ou
> >>
>
>
Attachment:
signature.asc
Description: PGP signature
