Re: [PATCH rdma-next v2] overflow: Fix -Wtype-limits compilation warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 15, 2019 at 06:45:23PM +0000, Jason Gunthorpe wrote:
> On Tue, Mar 12, 2019 at 09:43:39PM +0200, Leon Romanovsky wrote:
> > On Tue, Mar 12, 2019 at 12:36:48PM -0700, Bart Van Assche wrote:
> > > On Mon, 2019-03-11 at 14:33 +0200, Leon Romanovsky wrote:
> > > > -               _s >= 0 && _s < 8 * sizeof(*d) ? _s : 0;                \
> > > > +               (_s == 0 || _s > 0) && _s < 8 * sizeof(*d) ? _s : 0;    \
> > >
> > > Hi Leon,
> > >
> > > Is there any particular reason why (_s == 0 || _s > 0) is used above instead
> > > of is_non_negative(_s)?
> >
> > There is no reason, except that I wanted to get rid of this fix as soon
> > as possible, this warning distract users of my CI system.
>
> So v3 then?

Can you fix it in-tree, please? If you plan to send extra PR to Linus this merge window.
Otherwise, I'll send it on Sunday.

Thanks

>
> Jason

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux