On Sun, Mar 03, 2019 at 06:34:42PM +0200, Max Gurtovoy wrote: > > On 2/7/2019 8:12 PM, Sagi Grimberg wrote: > > > > > From: Israel Rukshin <israelr@xxxxxxxxxxxx> > > > > > > Instead of adding many arguments to RDMA mapping functions with PI, > > > create a new data structure 'ib_scatterlist' which contains the needed > > > information on a mapped scatterlist. In the future, this will also be > > > used by ULPs that define these attributes explicitly. > > > > While this can be viewed as a natural packing of a scatterlist > > attributes it seems unneeded. Personally I would rather pass > > the arguments explicitly. > > > > If you really don't want to do that, would it make sense to split the > > mapping APIs to data vs. pi? > > > I prefer to ease the API. This was the whole point (+ perf improvements) of > this patches. I've always been prefering more entry points to gaint multiplexor entry points.. It is usually more understandable. > > Something like the following maybe? > > ret = ib_map_mr_sg(mr, sg, nents, &offset, PAGE_SIZE); > > > > ... > > > > ret = ib_map_mr_sg_pi(mr, meta_sg, meta_nents, &meta_offset, > > PAGE_SIZE); So call the normal map_mr then 'augment' it with pi data? Not an unreasonable way to go.. Jason
