Re: [PATCH 04/17] RMDA/core: Introduce ib_scatterlist structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




From: Israel Rukshin <israelr@xxxxxxxxxxxx>

Instead of adding many arguments to RDMA mapping functions with PI,
create a new data structure 'ib_scatterlist' which contains the needed
information on a mapped scatterlist. In the future, this will also be
used by ULPs that define these attributes explicitly.

While this can be viewed as a natural packing of a scatterlist
attributes it seems unneeded. Personally I would rather pass
the arguments explicitly.

If you really don't want to do that, would it make sense to split the
mapping APIs to data vs. pi?

Something like the following maybe?
	ret = ib_map_mr_sg(mr, sg, nents, &offset, PAGE_SIZE);

	...

	ret = ib_map_mr_sg_pi(mr, meta_sg, meta_nents, &meta_offset, PAGE_SIZE);

Can't see why that API wouldn't work unless I'm missing something (maybe
for the theoretical case where the data and pi are interleaved in the
first place?)

Thoughts?



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux