> -----Original Message-----
> From: Nikolova, Tatyana E <tatyana.e.nikolova@xxxxxxxxx>
> Sent: Friday, January 25, 2019 6:32 PM
> To: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>; dledford@xxxxxxxxxx;
> jgg@xxxxxxxxxxxx
> Cc: linux-rdma@xxxxxxxxxxxxxxx; BMT@xxxxxxxxxxxxxx; Saleem, Shiraz
> <shiraz.saleem@xxxxxxxxx>
> Subject: RE: [PATCH RESEND v1 rdma-next 3/3] RDMA/IWPM: Support no
> port mapping requirements
>
> Hi Steve,
>
> Your port mapper changes look good. I just have some minor comments.
>
Thanks for reviewing!
> It appears the port mapping will fail, if the kernel port mapper is
updated
> with your changes but the user space port mapper isn't (ABI version 3). Is
> there a reason why the error is silent in this case?
>
With testing, I see it works with kernel ABI4 and user ABI3. How do you
see it failing exactly? Maybe I'm missing something.
> > static const char iwpm_ulib_name[IWPM_ULIBNAME_SIZE] =
> > "iWarpPortMapperUser"; -static int iwpm_ulib_version = 3;
> > +u16 iwpm_user_ulib_version = IWPM_UABI_VERSION_MIN;
>
> Rename iwpm_user_ulib_version to iwpm_ulib_version
>
Seems good.
> > +
> > +int iwpm_send_hello(u8 nl_client, int iwpm_pid, u16 abi_version) {
> > + struct sk_buff *skb = NULL;
> > + struct nlmsghdr *nlh;
> > + u32 msg_seq;
>
> Remove msg_seq, because it isn't used in the function
>
Yes.
> > +/* iwarp port mapper message flags */
> > +enum {
> > +
> > + /* Do not map the port for this IWPM request */
> > + IWPM_FLAGS_NO_PORT_MAP = (1 << 0),
>
> Use BIT(0) for consistency within the patch
>
I've seen other maintainers suggest BIT() is obfuscating. Jason?
