Hi Steve,
Your port mapper changes look good. I just have some minor comments.
It appears the port mapping will fail, if the kernel port mapper is updated with your changes but the user space port mapper isn't (ABI version 3). Is there a reason why the error is silent in this case?
> static const char iwpm_ulib_name[IWPM_ULIBNAME_SIZE] =
> "iWarpPortMapperUser"; -static int iwpm_ulib_version = 3;
> +u16 iwpm_user_ulib_version = IWPM_UABI_VERSION_MIN;
Rename iwpm_user_ulib_version to iwpm_ulib_version
> +
> +int iwpm_send_hello(u8 nl_client, int iwpm_pid, u16 abi_version) {
> + struct sk_buff *skb = NULL;
> + struct nlmsghdr *nlh;
> + u32 msg_seq;
Remove msg_seq, because it isn't used in the function
> +/* iwarp port mapper message flags */
> +enum {
> +
> + /* Do not map the port for this IWPM request */
> + IWPM_FLAGS_NO_PORT_MAP = (1 << 0),
Use BIT(0) for consistency within the patch
Thank you,
Tatyana
