Re: [PATCH rdma-core v2] verbs: Fix UD pingpong buffer validation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 24, 2019 at 04:13:48PM +0200, Gal Pressman wrote:
> The buffer allocated in the test has extra 40 bytes reserved for GRH for
> both the client and the server, while the actual payload starts at
> offset 40.
>
> Since the buffer validation applies to the payload only, we should take
> this offset into account:
> As the sender, make sure to fill the payload starting at offset 40 as
> all data before that will not be sent on ibv_post_send.
> As the receiver, make sure to validate the payload starting at offset 40
> as all data before that is not part of the actual payload (GRH/not
> valid).
>
> Also, The buffer validation option doesn't require an extra parameter,
> remove the extra ':'.
>
> Fixes: 099c5aa50bc8 ("libibverb/examples: Add command line option to enable buffer validation")
> Cc: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
> Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx>
> ---

Thanks, I fixed all other pingpongs too and merged it.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux