Re: [PATCH rdma-next 1/3] IB/usnic: Fix out of bounds index check in query pkey

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks, 

Acked-by: Parvi Kaustubhi <pkaustub@xxxxxxxxx>

> On Jan 7, 2019, at 7:27 AM, Gal Pressman <galpress@xxxxxxxxxx> wrote:
> 
> The pkey table size is one element, index should be tested for > 0
> instead of > 1.
> 
> Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver")
> Cc: Christian Benvenuti <benve@xxxxxxxxx>
> Cc: Nelson Escobar <neescoba@xxxxxxxxx>
> Cc: Parvi Kaustubhi <pkaustub@xxxxxxxxx>
> Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx>
> ---
> drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
> index 1d4abef17e38..63c7b48774e9 100644
> --- a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
> +++ b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
> @@ -449,7 +449,7 @@ struct net_device *usnic_get_netdev(struct ib_device *device, u8 port_num)
> int usnic_ib_query_pkey(struct ib_device *ibdev, u8 port, u16 index,
> 				u16 *pkey)
> {
> -	if (index > 1)
> +	if (index > 0)
> 		return -EINVAL;
> 
> 	*pkey = 0xffff;
> -- 
> 2.7.4
> 





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux