RE: [EXT] [PATCH rdma-next 3/3] RDMA/qedr: Fix out of bounds index check in query pkey

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Gal Pressman <galpress@xxxxxxxxxx>
> Sent: Monday, January 07, 2019 5:28 PM
> 
> The pkey table size is QEDR_ROCE_PKEY_TABLE_LEN, index should be tested
> for >= QEDR_ROCE_PKEY_TABLE_LEN instead of >
> QEDR_ROCE_PKEY_TABLE_LEN.
> 
> Fixes: a7efd7773e31 ("qedr: Add support for PD,PKEY and CQ verbs")
> Cc: Michal Kalderon <Michal.Kalderon@xxxxxxxxxx>
> Cc: Ariel Elior <Ariel.Elior@xxxxxxxxxx>
> Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx>
> ---
>  drivers/infiniband/hw/qedr/verbs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/qedr/verbs.c
> b/drivers/infiniband/hw/qedr/verbs.c
> index b342a70e2814..bf37673a8302 100644
> --- a/drivers/infiniband/hw/qedr/verbs.c
> +++ b/drivers/infiniband/hw/qedr/verbs.c
> @@ -67,7 +67,7 @@ static inline int qedr_ib_copy_to_udata(struct ib_udata
> *udata, void *src,
> 
>  int qedr_query_pkey(struct ib_device *ibdev, u8 port, u16 index, u16
> *pkey)  {
> -       if (index > QEDR_ROCE_PKEY_TABLE_LEN)
> +       if (index >= QEDR_ROCE_PKEY_TABLE_LEN)
>                 return -EINVAL;
> 
>         *pkey = QEDR_ROCE_PKEY_DEFAULT;
> --
> 2.7.4

Thanks, 

Acked-by: Michal Kalderon <michal.kalderon@xxxxxxxxxxx>






[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux