On Fri, Jan 04, 2019 at 06:01:55PM +0000, Weiny, Ira wrote: > > > +DECLARE_EVENT_CLASS(ib_mad_agent_template, > > > + TP_PROTO(struct ib_mad_agent_private *agent), > > > + TP_ARGS(agent), > > > + > > > + TP_STRUCT__entry( > > > + __string(dev_name, agent->agent.device->name) > > > > I'm trying to get rid of device->name, this should be > > dev_name(&device->dev) > > > > Though, should it use the stable device index instead? > > Both good points. My excuse is me basing them off my old work and not having correlated the upstream discussions with these patches... I'll respin with the device index as that is most unique. > > I still think there needs to be 'super easy' device index to name decoding... But I'm not really up on what has been done so forgive me if it is there. rdmatool does that, most probably not in "super easy" way, but easy enough. [leonro@server ~]$ rdma dev 1: mlx5_0: node_type ca fw 3.8.9999 node_guid 5254:00c0:fe12:3455 sys_image_guid 5254:00c0:fe12:3455 ^ device index. Thanks > > Ira >
Attachment:
signature.asc
Description: PGP signature
