On Mon, Jan 07, 2019 at 11:01:13AM -0800, Steve Wise wrote:
> A recent regression causes a null ptr crash when dumping cm_id resources.
> The cma is incorrectly adding all cm_id restrack resources as kernel mode.
>
> Fixes: af8d70375d56 ("RDMA/restrack: Resource-tracker should not use uobject pointers")
> Signed-off-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/infiniband/core/cma.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
> index 63a7cc00bae0..84f077b2b90a 100644
> --- a/drivers/infiniband/core/cma.c
> +++ b/drivers/infiniband/core/cma.c
> @@ -494,7 +494,10 @@ static void _cma_attach_to_dev(struct rdma_id_private *id_priv,
> id_priv->id.route.addr.dev_addr.transport =
> rdma_node_get_transport(cma_dev->device->node_type);
> list_add_tail(&id_priv->list, &cma_dev->id_list);
> - rdma_restrack_kadd(&id_priv->res);
> + if (id_priv->res.kern_name)
> + rdma_restrack_kadd(&id_priv->res);
> + else
> + rdma_restrack_uadd(&id_priv->res);
> }
>
Jason, Doug
Please be aware that this bugfix is needed in for-next too.
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
Thanks
Attachment:
signature.asc
Description: PGP signature
