On Thu, Jan 3, 2019 at 2:34 AM Jason Gunthorpe <jgg@xxxxxxxxxxxx> wrote:
>
> On Mon, Dec 31, 2018 at 01:10:05AM -0500, Devesh Sharma wrote:
>
> > @@ -902,6 +906,7 @@ int bnxt_qplib_create_qp(struct bnxt_qplib_res *res, struct bnxt_qplib_qp *qp)
> > }
> > hw_sq_send_ptr = (struct sq_send **)sq->hwq.pbl_ptr;
> > if (psn_sz) {
> > +
> > psn_search_ptr = (struct sq_psn_search **)
> > &hw_sq_send_ptr[get_sqe_pg
> > (sq->hwq.max_elements)];
>
> extra new line?
Unforced! will fix this too.
>
> Jason
>
> > diff --git a/drivers/infiniband/hw/bnxt_re/roce_hsi.h b/drivers/infiniband/hw/bnxt_re/roce_hsi.h
> > index 42dba3a..7e3bbfd 100644
> > +++ b/drivers/infiniband/hw/bnxt_re/roce_hsi.h
> > @@ -162,6 +162,24 @@ struct sq_psn_search {
> > #define SQ_PSN_SEARCH_FLAGS_SFT 24
> > };
> >
> > +/* sq_psn_search_ext (size:128b/16B) */
> > +struct sq_psn_search_ext {
> > + __le32 opcode_start_psn;
> > + #define SQ_PSN_SEARCH_EXT_START_PSN_MASK 0xffffffUL
> > + #define SQ_PSN_SEARCH_EXT_START_PSN_SFT 0
> > + #define SQ_PSN_SEARCH_EXT_OPCODE_MASK 0xff000000UL
> > + #define SQ_PSN_SEARCH_EXT_OPCODE_SFT 24
> > + __le32 flags_next_psn;
> > + #define SQ_PSN_SEARCH_EXT_NEXT_PSN_MASK 0xffffffUL
> > + #define SQ_PSN_SEARCH_EXT_NEXT_PSN_SFT 0
> > + #define SQ_PSN_SEARCH_EXT_FLAGS_MASK 0xff000000UL
> > + #define SQ_PSN_SEARCH_EXT_FLAGS_SFT 24
> > + __le16 start_slot_idx;
> > + __le16 reserved16;
> > + __le32 reserved32;
> > +};
>
> More creative use of white space, can you fix all of these?
Will fix this too.
>
> Jason
