On Thu, 2018-12-20 at 18:44 +-0100, Christoph Hellwig wrote: +AD4 On Thu, Dec 20, 2018 at 10:43:18AM -0700, Jason Gunthorpe wrote: +AD4 +AD4 +AD4 - chunk-+AD4-coherent is an int not a bool since checkpatch complains about +AD4 +AD4 +AD4 using bool in structs+ADs see https://lkml.org/lkml/2017/11/21/384. +AD4 +AD4 +AD4 +AD4 :( bool is much more readable and there is no performance concern in +AD4 +AD4 this struct. I think checkpatch is overzealous here. +AD4 +AD4 Yes. Nevermind that this for bool vs bitfield. A int is worse in +AD4 every respect in the criteria used in that mail. (+-Joe Perches) Hi Joe, This is the second time that I see that the checkpatch complaint about using bool in a structure leads kernel contributors to a bad decision. Please consider removing that warning from checkpatch. Thanks, Bart.
