On Thu, Dec 20, 2018 at 10:43:18AM -0700, Jason Gunthorpe wrote: > > - chunk->coherent is an int not a bool since checkpatch complains about > > using bool in structs; see https://lkml.org/lkml/2017/11/21/384. > > :( bool is much more readable and there is no performance concern in > this struct. I think checkpatch is overzealous here. Yes. Nevermind that this for bool vs bitfield. A int is worse in every respect in the criteria used in that mail.