On Wed, 2018-12-19 at 18:24 +0000, Weiny, Ira wrote: > > > In addition I wrote a sample eBPF which shows how one can further > > > filter at the tracepoints to distill the information being traced. I > > > don't know if this should be submitted through another tree or if it > > > is ok to take though linux-rdma? > > > > I think it needs to go through the tracing subsystem tree, maintained by Ingo > > Molnar and Steven Rostedt. In addition, you need a MAINTAINERS file > > update to go along with this. The include/trace/events/ib*mad.h files should > > be under the INFINIBAND subsystem to patches to them get Cc:ed here. > > Same for the samples/bpf/ibumad_*.c files. > ^^^^^ > > I don't understand. > > The include/trace/events/ib*mad.h changes are the _only_ ones to the tracing subsystem. You're saying they should go under the IB subsystem. Which I where I posted them... No, I'm saying they should go through the tracing subsystem so they get that level of review and exposure, but that the INFINIBAND substem MAINTAINERS entry should get a new line indicating that our subsystem should be included on changes to those files. It doesn't mean that the files won't also flag as tracing files when someone runs the query on the MAINTAINERS file, it means both the tracing maintainers and linux- rdma will get Cc:ed on changes to these files. > > So what should go through the tracing subsystem? Send the whole series through there, just add the changes to the MAINTAINERS file I listed. > Regarding the samples/bpf/ibumad_*.c files, you said they should be the "same"? So the only change left is the samples/bpf/Makefile and the changes to the IB MAD files in the IB system... Yes, tag them as files under the INFINIBAND section of the MAINTAINERS file. Again, linux-rdma will get Cc:ed on patches to these files, but so will the main BPF maintianers. > Finally, do you mean the MAINTAINERS should be updated in the tracing subsystem or the IB subsystem? I mean what I said above: Add lines to the INFINIBAND subsystem section of the maintainers file so that we get Cc:ed on changes to these tracing system files. If you grep include/trace on the MAINTAINERS file, you will see this is a very common construct for the tracing subsystem. > Ira > > > > Ira > > > > > > [1] https://www.spinics.net/lists/linux-rdma/msg29109.html > > > > > > > > > Ira Weiny (6): > > > IB/MAD: Add send path trace points > > > IB/MAD: Add recv path trace point > > > IB/MAD: Add agent trace points > > > IB/UMAD: Add umad trace points > > > IB/MAD: Add SMP details to MAD tracing > > > BPF: Add sample code for new ib_umad tracepoint > > > > > > drivers/infiniband/core/mad.c | 95 ++++++++- > > > drivers/infiniband/core/user_mad.c | 7 + > > > include/trace/events/ib_mad.h | 391 > > +++++++++++++++++++++++++++++++++++++ > > > include/trace/events/ib_umad.h | 140 +++++++++++++ > > > samples/bpf/Makefile | 3 + > > > samples/bpf/ibumad_kern.c | 123 ++++++++++++ > > > samples/bpf/ibumad_user.c | 120 ++++++++++++ > > > 7 files changed, 878 insertions(+), 1 deletion(-) create mode 100644 > > > include/trace/events/ib_mad.h create mode 100644 > > > include/trace/events/ib_umad.h create mode 100644 > > > samples/bpf/ibumad_kern.c create mode 100644 > > > samples/bpf/ibumad_user.c > > > > > > > -- > > Doug Ledford <dledford@xxxxxxxxxx> > > GPG KeyID: B826A3330E572FDD > > Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD -- Doug Ledford <dledford@xxxxxxxxxx> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Attachment:
signature.asc
Description: This is a digitally signed message part
