Hi Adit, I have noticed that this field is checked only in modify_qp command. For all other command we have: ret = pvrdma_cmd_post() if (ret < 0) error; else ok; While for modify_qp the flow is a bit different: ret = pvrdma_cmd_post() if (ret < 0) error; else else if (rsp.hdr.err > 0) error; else ok Any reason behind this? If not, can we get rid of this field? I understand that this is command interface with the device and cannot just be deleted but can we at least be consist with checking return value from command execution? and if this field is never used then at least add some note in struct definition saying something like "deprecated field"? Thanks, Yuval
